]> dgit.raspbian.org Git - gnome-shell.git/commit
Require both mouse and keyboard grabs for some grabs to be successful
authorSebastian Keller <skeller@gnome.org>
Sat, 30 Apr 2022 06:18:39 +0000 (08:18 +0200)
committerMarge Bot <marge-bot@gnome.org>
Wed, 4 May 2022 17:28:08 +0000 (17:28 +0000)
commit23b4eb459ed66b2d268b4b28ba0fd0fc3c90177d
tree45032143ca97ec5a179f4b400fd60006704f5f9b
parent3e8164cc36e938fcc65a3fe84ebfc8579387c66a
Require both mouse and keyboard grabs for some grabs to be successful

Commit 7419674b changed some grabs from requiring both mouse and
keyboard grabs to be considered successful to only requiring either of
them.

Due to this it was possible for example to open the overview or the
screenshot UI with a client (such as Chrome when opening a menu) holding
the mouse grab. This then made it impossible to interact with the UI
using the mouse (or keyboard) and if attempted could result in an
unresponsive UI.

Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5414
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2287>
js/ui/grabHelper.js
js/ui/lookingGlass.js
js/ui/modalDialog.js
js/ui/overview.js